|WARNING| dev: hide internal type for device comparison

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166583

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-06

# DPDK Patch Review

## Summary

This patch moves the `rte_dev_cmp_t` typedef from `rte_dev.h` to `bus_driver.h` to reduce header dependencies. The change is essentially a refactoring that reorganizes type definitions without altering functionality.

## Findings

### Errors

None.

### Warnings

**1. Missing release notes**

This patch changes the public API surface by removing `rte_dev_cmp_t` from `rte_dev.h`. While the type is only used internally by bus operations and not referenced by any public API functions, applications that directly include `rte_dev.h` and reference this type will break. This should be documented in the release notes under API changes.

Suggested fix: Add an entry to `doc/guides/rel_notes/release_25_03.rst` (or the current release file):
```rst
API Changes
-----------

* **eal: Moved rte_dev_cmp_t type definition.**

  The ``rte_dev_cmp_t`` typedef has been moved from ``rte_dev.h`` to
  ``bus_driver.h`` as it is only used in bus driver operations. Applications
  that reference this type should include ``bus_driver.h`` instead.
```

**2. Forward declaration placement**

The patch adds forward declarations `struct rte_dev_iterator;` and `struct rte_driver;` at the top of `bus_driver.h`, but only `rte_dev_cmp_t` (which references `struct rte_device`) appears to use them in the visible diff. Verify that these forward declarations are actually needed by other code in `bus_driver.h` not shown in the patch context.

If `struct rte_dev_iterator` and `struct rte_driver` are not used by any function signatures or typedefs in `bus_driver.h`, they should be removed.

### Info

**1. Header dependency reduction is good practice**

This change follows good software engineering practice by reducing unnecessary header dependencies. `rte_dev.h` is a commonly included header, so removing the need for it to pull in bus-specific types is beneficial.

**2. Consistent documentation**

The Doxygen comment for `rte_dev_cmp_t` is preserved verbatim in its new location, which is correct. The documentation remains accurate and complete.

**3. Test file update is correct**

Adding `#include <rte_dev.h>` to `app/test/test_vdev.c` is necessary because that file likely used types from `rte_dev.h` that were previously included transitively via `bus_driver.h`. This explicit inclusion is the correct fix.

## Conclusion

The patch is technically correct and improves header organization. The only required change is to add a release note documenting the API surface change. The forward declarations should be verified as necessary (this may require reviewing the full `bus_driver.h` file beyond what's shown in the patch).