|WARNING| [v2] dev: fix hotplug notification to secondary

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166599

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-07

# DPDK Patch Review

## Summary
This patch fixes a logic error in hotplug notification to secondary processes. The error is in the evaluation of `no_shconf` to determine whether multi-process communication should be performed.

---

## Errors

### 1. Logic Error in Boolean Expression (FIXED BY THIS PATCH)

**Original code:**
```c
bool do_mp = !!internal_conf->no_shconf;
```

**Fixed code:**
```c
bool do_mp = internal_conf->no_shconf == 0;
```

The original code sets `do_mp = true` when shared config is disabled (`no_shconf != 0`), which is backwards. Multi-process support requires shared config, so `do_mp` should be true when `no_shconf` is zero (shared config is enabled).

**Note:** This is the bug being fixed by the patch, not a new issue to report.

---

## Warnings

None.

---

## Info

### Style: Unnecessary Explicit Comparison

The fixed code uses an explicit comparison against zero:
```c
bool do_mp = internal_conf->no_shconf == 0;
```

This is acceptable per DPDK guidelines which require explicit comparisons for integers. However, since `do_mp` is a `bool` and the expression evaluates the logical inverse of `no_shconf`, an alternative would be:
```c
bool do_mp = !internal_conf->no_shconf;
```

Both forms are acceptable. The explicit comparison makes the zero-test intent clearer, while the negation form is more concise. The patch's choice is fine.

---

## Verification Checklist

- [x] Logic error correctly identified and fixed
- [x] `bool` type used appropriately for flag variable
- [x] Explicit comparison used (per guidelines for integers)
- [x] Fix is minimal and targeted
- [x] Both occurrences of the bug are fixed (lines 272 and 431)
- [x] No resource management issues
- [x] No API changes
- [x] Code style compliant

---

## Overall Assessment

**The patch is correct and ready for merge.**

The fix properly inverts the logic to ensure multi-process notification occurs when shared config is enabled (`no_shconf == 0`) and is skipped when running without shared config (`no_shconf != 0`). The bug was likely introduced during a last-minute refactoring (as noted in the commit message), and this patch restores the correct behavior.