|WARNING| net/nfp: fix UB in BAR size shift operations

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166613

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-07

# DPDK Patch Review

## Patch Summary
Fixes undefined behavior in NFP driver's BAR size calculations by replacing `1 << bitsize` with `RTE_BIT64()`.

---

## ERRORS

None found.

---

## WARNINGS

None found.

---

## INFO

### 1. Patch correctly addresses a 64-bit bitmask UB issue

The patch fixes exactly the pattern described in AGENTS.md under "Bitmask shift using `1` instead of `1ULL` on 64-bit masks". The literal `1` is `int` (32 bits), and shifting it by 31 or more is undefined behavior. When used with `uint64_t` operands (`base`, `offset`), the upper 32 bits are silently zeroed even for shifts < 32.

The fix using `RTE_BIT64()` is the preferred DPDK idiom for this pattern.

### 2. Consistent application across all instances

The patch correctly updates all four instances where `1 << bar->bitsize` (or expressions derived from it) appear:
- `NFP_PCIE_P2C_FIXED_SIZE`
- `NFP_PCIE_P2C_BULK_SIZE`  
- `NFP_PCIE_P2C_GENERAL_SIZE`
- The bounds check in `matching_bar_exist()`

This ensures no latent bugs remain from the same root cause.

### 3. Release notes not required

This is a correctness bug fix in driver internal code. Release notes are only required for API changes, new features, or new drivers. Internal bug fixes sent to stable@ do not need release notes per AGENTS.md guidelines.

---

## SUMMARY

**Recommendation: ACCEPT**

This patch correctly fixes a real undefined behavior / correctness bug (high-value finding). The fix is appropriate, consistent, and follows DPDK conventions. The `Fixes:` tags and `Cc: stable at dpdk.org` are correctly applied for backporting to LTS releases.