|WARNING| build: fix libpcap detection with unusable header

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166611

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-07

# DPDK Patch Review

## Summary
The patch addresses a build system issue where an empty or broken `<pcap.h>` header file can pass the detection checks but cause build failures. The fix strengthens the detection by requiring an actual pcap symbol to be present.

---

## Errors

None identified.

---

## Warnings

None identified.

---

## Info

### 1. Build system robustness improvement
The change from `cc.has_header()` to `cc.has_header_symbol()` with `pcap_create` as the test symbol is a good defensive approach. This ensures the header is not only present but actually usable.

### 2. `-D_GNU_SOURCE` flag usage
The addition of `-D_GNU_SOURCE` in the `has_header_symbol()` call is appropriate for ensuring maximum visibility of symbols in a GNU environment, though the patch could benefit from a comment explaining why this flag is needed if it's not obvious from the pcap API.

### 3. Comment accuracy
The comment "has_header() passes even when pcap.h is empty" clearly explains the problem being solved, which is helpful for future maintainers.

### 4. Choice of test symbol
Using `pcap_create` as the test symbol is reasonable - it's a core libpcap function introduced in libpcap 1.0.0 (2008), so it should be widely available in any modern installation. This is a good balance between coverage and compatibility.

---

## Conclusion

The patch correctly addresses the stated problem with a minimal, focused change. The approach of requiring a real symbol declaration rather than just header presence is the right solution for detecting broken or empty header files. No correctness bugs, style violations, or guideline violations were identified.