|WARNING| [26.11] ethdev: remove flow metadata symbol aliases

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166730

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-13

# DPDK Patch Review

## Summary
This patch removes version aliases for flow metadata symbols after an ABI version bump. The changes are straightforward cleanup work following proper DPDK ABI evolution practices.

---

## Errors

None.

---

## Warnings

**Warning: Missing release notes update**
- **Location**: No corresponding update in `doc/guides/rel_notes/release_26_11.rst`
- **Issue**: Removal of symbol versioning and the `use_function_versioning` flag should be documented in release notes as it affects the ABI
- **Suggested fix**: Add a section to the release notes:
```rst
* **ethdev: Removed flow metadata symbol version aliases.**

  Removed version aliases for ``rte_flow_dynf_metadata_register()``
  and removed experimental tags from ``rte_flow_dynf_metadata_offs``
  and ``rte_flow_dynf_metadata_mask`` following the ABI version bump.
```

---

## Info

**Info: Correct symbol export transition**
- The patch correctly transitions symbols from experimental to stable:
  - `RTE_EXPORT_EXPERIMENTAL_SYMBOL` - `RTE_EXPORT_SYMBOL` for the two global variables
  - Removes versioned symbol macros (`RTE_DEFAULT_SYMBOL` / `RTE_VERSION_EXPERIMENTAL_SYMBOL`)
  - Removes `use_function_versioning` flag which is no longer needed

**Info: Proper cleanup approach**
- The removal of duplicate `rte_flow_dynf_metadata_register()` wrapper at lines 318-322 is correct - the versioning macros generated this automatically, so the manual wrapper is no longer needed
- The function now has a standard definition with `RTE_EXPORT_SYMBOL` annotation

**Info: ABI compatibility note**
- This change is appropriate for a major release (26.11) where ABI breaks are allowed
- Applications built against the previous ABI will need to be rebuilt

---

## Overall Assessment

The patch is technically correct and follows DPDK's ABI versioning practices properly. The only missing piece is documentation in the release notes to inform users of this ABI change.
Traceback (most recent call last):
  File "/home-local/jenkins-local/jenkins-agent/workspace/AI-Code-Review/dpdk/devtools/ai/review-patch.py", line 1358, in <module>
    main()
  File "/home-local/jenkins-local/jenkins-agent/workspace/AI-Code-Review/dpdk/devtools/ai/review-patch.py", line 1354, in main
    sys.exit(classify_review(review_text, args.output_format))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home-local/jenkins-local/jenkins-agent/workspace/AI-Code-Review/dpdk/devtools/ai/review-patch.py", line 180, in classify_review
    elif curr_state == ReviewParseState.IN_ERROR and not re.match(
         ^^^^^^^^^^
UnboundLocalError: cannot access local variable 'curr_state' where it is not associated with a value