|WARNING| [26.11] net/mlx5: remove versioned symbols aliases

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166731

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-13

# DPDK Patch Review

## Summary

This patch removes versioned symbol aliases for four functions after an ABI version bump. The code correctly transitions from versioned symbols to standard symbol export macros. Overall, the patch is clean with no correctness bugs detected.

## Warnings

### Missing Release Notes (Warning)

This patch removes versioned symbols and updates the exported API macros, which is an ABI-related change. According to the guidelines, changes to existing API require release notes.

**Suggested action:** Add a release notes entry in `doc/guides/rel_notes/release_26_11.rst` documenting the removal of versioned symbols for these four functions (since they are now the default stable symbols after the ABI version bump).

Example:
```rst
* **net/mlx5: Removed versioned symbol aliases.**

  Removed versioned symbol aliases for functions that were promoted to stable ABI:
  ``rte_pmd_mlx5_driver_event_cb_register``,
  ``rte_pmd_mlx5_driver_event_cb_unregister``,
  ``rte_pmd_mlx5_enable_steering``,
  ``rte_pmd_mlx5_disable_steering``.
```

### Meson Build Variable Removal (Info)

The removal of `use_function_versioning = true` from `meson.build` is correct for this patch, but ensure no other code in the mlx5 driver still depends on function versioning. If other versioned symbols remain elsewhere in the driver, this removal may be premature.

**Suggested verification:** Check if there are other uses of `RTE_VERSION_SYMBOL` macros in the mlx5 driver that would require `use_function_versioning = true`.

---

## Code Quality Assessment

 **Correctness:** No bugs detected  
 **Style:** Conforms to DPDK coding standards  
 **API Tags:** Export macros correctly placed  
 **Documentation:** Release notes should be updated  

The patch is well-structured and the symbol export transition follows the correct pattern for post-ABI-bump cleanup.
Traceback (most recent call last):
  File "/home-local/jenkins-local/jenkins-agent/workspace/AI-Code-Review/dpdk/devtools/ai/review-patch.py", line 1358, in <module>
    main()
  File "/home-local/jenkins-local/jenkins-agent/workspace/AI-Code-Review/dpdk/devtools/ai/review-patch.py", line 1354, in main
    sys.exit(classify_review(review_text, args.output_format))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home-local/jenkins-local/jenkins-agent/workspace/AI-Code-Review/dpdk/devtools/ai/review-patch.py", line 180, in classify_review
    elif curr_state == ReviewParseState.IN_ERROR and not re.match(
         ^^^^^^^^^^
UnboundLocalError: cannot access local variable 'curr_state' where it is not associated with a value