|WARNING| meson: bump the minimum required version to 0.60.0

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166753

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-16

# Review of DPDK Patch: meson: bump the minimum required version to 0.60.0

## Summary

This patch updates the minimum Meson version from 0.57.2 to 0.60.0 and enables `--fatal-meson-warnings` in CI. The changes are minimal and appear correct, but there are a few process and style items to address.

---

## Errors

None.

---

## Warnings

### Documentation Gap

**File:** None (missing release notes update)

The patch changes the minimum required version of the build system, which affects all DPDK users and packagers. This is a significant change that should be documented in release notes.

**Suggested fix:**
Add a section to `doc/guides/rel_notes/release_26_07.rst` (or the appropriate current release notes file) under a "Build System Requirements" or "Known Issues/Limitations" section:

```rst
Build System Requirements
~~~~~~~~~~~~~~~~~~~~~~~~~~

* The minimum supported Meson version is now 0.60.0 (previously 0.57.2).
  This change eliminates warnings about the use of ``install_tag`` in documentation targets.
```

### Commented Windows Meson Version

**File:** meson.build, line 14

The commented line `# meson_version_windows: '>= 1.5.2'` is confusing. If this is intended for future use, it should have a comment explaining why it's commented out and when it should be enabled. If it's obsolete, it should be removed.

**Suggested fix:**
Either add an explanatory comment or remove the line:

```python
meson_version: '>= 0.60.0'
# TODO: Windows builds require >= 1.5.2 for XYZ feature (uncomment when...)
```

or simply remove it if no longer relevant.

---

## Info

### CI Script Enhancement

The addition of `--fatal-meson-warnings` to CI is a good proactive measure to catch future build system issues. This aligns with the existing `-Dwerror=true` approach for C code warnings.

### Version Selection

Meson 0.60.0 was released in December 2021, which should be widely available in stable distributions by 2026. This is a reasonable minimum version to target.

---

## Final Assessment

The core change (bumping Meson version requirement) is straightforward and correct. The main improvement needed is documentation in release notes, as this is a user-visible change that affects build system requirements.