|WARNING| net/mlx5: revert fallback to Verbs Tx allocation

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166792

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-20

# Review of PATCH: net/mlx5: revert fallback to Verbs Tx allocation

## ERRORS

None found.

## WARNINGS

**1. .mailmap entry removal appears unrelated to the main fix**

The patch removes a single .mailmap entry:
```diff
-Banoth Saikumar <banoth.saikumar at oracle.com>
```

This change is not explained in the commit message and appears unrelated to the DevX CQ allocation fix. The .mailmap file is used to consolidate contributor identities in git history, and removing an entry should either be done in a separate patch with justification, or explained in the commit message if it's related to the technical change.

**2. Missing release notes update**

The patch fixes a Windows-specific failure in DevX CQ creation, which is a significant bug fix affecting device initialization. According to the guidelines, "Changes to existing API require release notes" and "Important changes" should be documented. This fix should be mentioned in the current release notes (likely `doc/guides/rel_notes/release_26_07.rst` given the July 2026 patch date) under "Fixed Issues" or similar section.

**3. Limited context in commit message**

The commit message states "On Windows, DevX CQ creation was failing because of a different allocation fallback behaviour" but doesn't explain:
- What the original commit was trying to achieve
- Why the fallback behavior differs on Windows
- What specific failure mode was observed (error message, return code, etc.)
- Whether this affects Linux or other platforms

A more detailed explanation would help reviewers and future maintainers understand the root cause.

## INFO

**1. Code change review**

The actual code change is minimal and focused:
```c
-if (priv->sh->config.txq_mem_algn == 0 || !mlx5_devx_obj_ops_en(priv->sh))
+if (priv->sh->config.txq_mem_algn == 0)
```

This removes the `!mlx5_devx_obj_ops_en(priv->sh)` condition, which was causing the function to return early when DevX objects were not enabled. The revert appears to restore the intended behavior where consecutive Tx memory allocation proceeds regardless of DevX object availability.

**2. Comparison style**

The code uses explicit comparison `== 0` which is consistent with DPDK style requirements for integer comparisons.

**3. Stable backport**

The patch is correctly tagged with `Cc: stable at dpdk.org` and includes a `Fixes:` tag, indicating this should be backported to stable releases.

## SUMMARY

The code change itself is clean and focused. The main issues are:
1. An unexplained .mailmap modification that should be in a separate patch
2. Missing release notes documentation for this bug fix
3. A sparse commit message that could provide more context about the failure mode

The correctness of the code change looks good - removing the DevX check allows the allocation path to proceed as originally intended before commit 4abc12b9331c.