|SUCCESS| [v2] app/testpmd: fix segfault in flow rule parser

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/166861

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-21

# DPDK Patch Review: app/testpmd: fix segfault in flow rule parser

## Summary
This patch fixes a critical use-after-free bug in testpmd's flow rule parser by replacing automatic-storage-duration compound literals with static arrays.

---

## Errors

None.

---

## Warnings

None.

---

## Info

### Correctness Analysis

**Use-after-free fix is correct.** The patch addresses a real lifetime issue:

1. `NEXT_ENTRY()` expands to a compound literal with automatic storage duration
2. Parser stores pointers to these literals in `ctx->next[]`
3. Pointers are dereferenced after the function returns
4. Making the arrays `static const` extends their lifetime beyond the function scope

The fix is appropriate for all three locations (`parse_vc_spec`, `parse_vc_action_rss_type`, `parse_vc_action_rss_queue`).

### Style Observations

- **Variable declarations:** The patch follows C99 style by declaring `static const` arrays at point of use within basic blocks. Both declaration at block start and at point-of-first-use are acceptable per DPDK style; this patch uses the latter.

- **Naming:** Array names (`next_prefix`, `next_rss_type`, `next_rss_queue`) are descriptive and follow lowercase-with-underscores convention.

- **const correctness:** The arrays are properly declared `const` since their contents are never modified.

### Code Quality

- **Minimal change:** The patch changes only what is necessary to fix the bug, without refactoring unrelated code.

- **Consistency:** All three affected functions receive the same pattern of fix.

- **No new allocations:** Using static storage avoids runtime allocation overhead while fixing the lifetime issue.

---

## Conclusion

**This patch is correct and ready for merge.** It fixes a genuine use-after-free bug with an appropriate solution. The static arrays have the correct lifetime, are properly const-qualified, and the change is minimal and consistent across all affected functions.