|WARNING| net/iavf: add clock read support

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166943

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-27

# DPDK Patch Review

## Summary
This patch adds clock read support to the iavf driver by implementing the `read_clock` ethdev operation. The implementation extracts PHC time reading logic into a reusable function.

---

## Errors

### 1. Header guard comment corrupted
**File:** `drivers/net/intel/iavf/iavf.h`  
**Line:** `#endif /* _IAVF_ETHDEV_H_ u*/`

The header guard closing comment has been corrupted with an extra "u" character and an incorrect name. It should match the opening guard.

**Fix:**
```c
#endif /* _IAVF_ETHDEV_H_ */
```

---

## Warnings

### 1. Missing release notes update
This patch adds a new ethdev operation (`read_clock`) which is a user-visible feature addition. The release notes should be updated to document this new capability.

**Suggested action:**  
Add an entry to `doc/guides/rel_notes/release_26_07.rst` (or the appropriate current release notes file) under the "New Features" section describing the addition of clock read support to the iavf driver.

Example entry:
```rst
* **Added clock read support to iavf driver.**

  Implemented the ``read_clock`` ethdev operation in the iavf driver
  to enable reading the current PHC time in nanoseconds.
```

### 2. Missing documentation for new function
The new exported function `iavf_phc_get_time()` added to `iavf.h` lacks a Doxygen comment documenting its parameters, return value, and purpose.

**Fix:**
```c
/**
 * Get PHC time from the device
 *
 * @param adapter
 *   Pointer to the iavf adapter structure
 * @param time
 *   Pointer to store the PHC time in nanoseconds
 * @return
 *   - 0: Success
 *   - Negative value: Failure
 */
int iavf_phc_get_time(struct iavf_adapter *adapter, uint64_t *time);
```

---

## Info

### 1. Function ordering consideration
The new `iavf_dev_read_clock()` function is placed at the end of the file, far from the other ethdev ops implementations. While this works, grouping it with other ethdev operation implementations (near the other static functions implementing ethdev ops) would improve code organization and maintainability.

This is a minor style preference and not a requirement.

---

## Positive Observations

1. **Good refactoring:** The extraction of `iavf_phc_get_time()` from `iavf_get_phc_time()` properly separates concerns and enables code reuse.

2. **Proper error handling:** The `iavf_dev_read_clock()` function correctly checks for adapter state, capability flags, and propagates errors appropriately.

3. **Consistent error codes:** Returns standard error codes (`-EIO`, `-ENOTSUP`) matching DPDK conventions.

4. **Lock handling:** The spinlock usage in `iavf_phc_get_time()` is correct - acquired before the virtchnl operation and released on all paths including error paths.

5. **No resource leaks:** All error paths properly release the spinlock before returning.