|WARNING| mailmap: update Khadem Ullah email address
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Wed Jul 29 13:32:41 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/166996
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-07-29
# DPDK Patch Review
## Summary
This patch updates the `.mailmap` file to consolidate email addresses for a contributor. The change is straightforward and follows the correct mailmap format.
**Overall Assessment**: The patch is acceptable with one minor style issue.
---
## Errors
None.
---
## Warnings
**Line 2 of the diff hunk: mailmap entry format inconsistency**
The second mailmap entry on line 881 has inconsistent formatting:
```
+Khadem Ullah <khadem.systems at gmail.com> khadem <14pwcse1224 at uetpeshawar.edu.pk>
```
The format mixes a full name on the left side with just "khadem" on the right side. According to Git mailmap documentation and DPDK convention, both sides should have consistent name formatting. The entry should be:
```
Khadem Ullah <khadem.systems at gmail.com> Khadem Ullah <14pwcse1224 at uetpeshawar.edu.pk>
```
Or if the historical commits used "khadem" as the author name literally:
```
Khadem Ullah <khadem.systems at gmail.com> khadem <14pwcse1224 at uetpeshawar.edu.pk>
```
However, the latter would only be correct if past commits actually had "khadem" (lowercase, no surname) as the author name field. Verify the historical commit metadata to determine the correct format. If unsure, the first format (repeating the full name) is safer and matches the pattern on line 880.
---
## Info
The `.mailmap` file updates are administrative changes and do not require:
- Release notes
- Documentation updates
- Code style checks
- ABI compatibility review
The patch correctly uses alphabetical ordering within the 'K' section of the mailmap file.
More information about the test-report
mailing list