|WARNING| pw162481 [RFC PATCH v1 14/21] net/i40e: reimplement FDIR parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/162481

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_TC_OFFSET>
#2466: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:44:
+#define I40E_IPV6_TC_MASK	(0xFF << I40E_FDIR_IPv6_TC_OFFSET)

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#2474: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:52:
+ * Pattern: START -> ETH -> [VLAN] -> (IPv4 | IPv6) -> [TCP | UDP | SCTP | ESP | L2TPv3 | GTP] -> END

WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#2898: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:476:
+		memcpy(&filter->input.flow.ipv6_flow.src_ip, &ipv6_spec->hdr.src_addr, sizeof(ipv6_spec->hdr.src_addr));

WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#2902: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:480:
+		memcpy(&filter->input.flow.ipv6_flow.dst_ip, &ipv6_spec->hdr.dst_addr, sizeof(ipv6_spec->hdr.dst_addr));

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2921: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:499:
+	if (ipv6_spec->hdr.proto == I40E_IPV6_FRAG_HEADER) {
+		filter->input.pctype = I40E_FILTER_PCTYPE_FRAG_IPV6;
+	}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#2984: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:562:
+	if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3071: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:649:
+	if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3162: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:740:
+	if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#3171: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:749:
+	if (!CI_FIELD_IS_ZERO(&sctp_mask->hdr.tag)) {
+		filter->input.flow_ext.input_set |= I40E_INSET_SCTP_VT;
+	}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3418: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:996:
+		if (is_udp)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#3420: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:998:
+		else {

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3424: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1002:
+		if (is_udp)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#3426: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1004:
+		else {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#3448: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1026:
+
+}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#3464: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1042:
+	if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#3985: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1563:
+	if (ret) {
+		return ret;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#3990: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1568:
+	if (ret) {
+		return ret;
+	}

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#4175: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1753:
+	struct i40e_fdir_engine_priv *priv = ci_flow_engine_priv(&pf->flow_engine_conf, engine->type);

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#4203: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1781:
+	struct i40e_fdir_engine_priv *priv = ci_flow_engine_priv(&pf->flow_engine_conf, flow->engine_type);

total: 0 errors, 15 warnings, 4 checks, 4091 lines checked