|WARNING| pw162476 [RFC PATCH v1 10/21] net/ixgbe: reimplement FDIR parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/162476

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#1915: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:99:
+	if (signature_match(item)) {
+		fdir_ctx->rule.mode = RTE_FDIR_MODE_SIGNATURE;
+	}

ERROR:CODE_INDENT: code indent should use tabs where possible
#2389: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:573:
+^I^I^I               RTE_FLOW_NODE_EXPECT_SPEC_MASK |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#2390: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:574:
+^I^I^I               RTE_FLOW_NODE_EXPECT_RANGE,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#2398: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:582:
+^I^I^I               RTE_FLOW_NODE_EXPECT_SPEC_MASK,$

WARNING:LONG_LINE_COMMENT: line length of 115 exceeds 100 columns
#2537: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:721:
+ * Pattern: START -> [OUTER_ETH] -> (OUTER_IPv4|OUTER_IPv6) -> [UDP] -> (VXLAN|NVGRE) -> INNER_ETH -> [VLAN] -> END

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#2538: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:722:
+ * VxLAN:  START -> [OUTER_ETH] -> (OUTER_IPv4|OUTER_IPv6) -> UDP -> VXLAN -> INNER_ETH -> [VLAN] -> END

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2738: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:922:
+		if (eth_mask->hdr.dst_addr.addr_bytes[j] == 0xFF) {
+			rule->mask.mac_addr_byte_mask |= 0x1 << j;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2924: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1108:
+	if (action->type == RTE_FLOW_ACTION_TYPE_DROP) {
+		drop_action = action;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2935: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1119:
+	if (drop_action == NULL && action != NULL && action->type == RTE_FLOW_ACTION_TYPE_DROP) {
+		drop_action = action;
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fdir_ctx->rule.mode == RTE_FDIR_MODE_SIGNATURE'
#2954: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1138:
+	if ((fdir_ctx->rule.mode == RTE_FDIR_MODE_SIGNATURE) &&
+	    (fdir_ctx->fwd_action->type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fdir_ctx->fwd_action->type == RTE_FLOW_ACTION_TYPE_DROP'
#2954: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1138:
+	if ((fdir_ctx->rule.mode == RTE_FDIR_MODE_SIGNATURE) &&
+	    (fdir_ctx->fwd_action->type == RTE_FLOW_ACTION_TYPE_DROP)) {

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#3026: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1210:
+	if (fdir_ctx->aux_action != NULL && fdir_ctx->aux_action->type == RTE_FLOW_ACTION_TYPE_MARK) {

total: 3 errors, 7 warnings, 2 checks, 3210 lines checked