|SUCCESS| [1/1] ml/cnxk: support for 64-bit int type in metadata

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Tue Mar 31 19:56:10 CEST 2026


Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/162792

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-03-31

git commit 3eb64825d24
Author: Srikanth Yalavarthi <syalavarthi at marvell.com>
Subject: ml/cnxk: support for 64-bit int type in metadata

This patch adds support for 64-bit integer data types (INT64 and UINT64)
in model metadata for the cnxk ML driver.

> diff --git a/drivers/ml/cnxk/cn10k_ml_model.c b/drivers/ml/cnxk/cn10k_ml_model.c
> index 12a2dda800e..3eb64825d24 100644
> --- a/drivers/ml/cnxk/cn10k_ml_model.c
> +++ b/drivers/ml/cnxk/cn10k_ml_model.c
> @@ -33,6 +33,10 @@ cn10k_ml_io_type_map(uint8_t type)
>  		return RTE_ML_IO_TYPE_FP16;
>  	case 8:
>  		return RTE_ML_IO_TYPE_FP32;
> +	case 9:
> +		return RTE_ML_IO_TYPE_INT64;
> +	case 10:
> +		return RTE_ML_IO_TYPE_UINT64;
>  	}
>  
>  	return RTE_ML_IO_TYPE_UNKNOWN;

Does this function need a default case to handle invalid type values
explicitly?  Currently if type is greater than 10 or not matching any
case, it falls through to return RTE_ML_IO_TYPE_UNKNOWN, but having an
explicit default case would improve code clarity and follow the pattern
that would prevent future case additions from being missed.

[ ... ]


More information about the test-report mailing list