|SUCCESS| [v3] dts: update test suite names to be clear and consistent

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163803

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-08

I'll review this DPDK patch focusing on correctness, coding style, API requirements, and guideline violations.

commit 20260508141319.52648-1-abailey at iol.unh.edu
Author: Andrew Bailey <abailey at iol.unh.edu>

dts: update test suite names to be clear and consistent

This patch renames several DTS test suites to use more consistent and
descriptive names, removing PMD prefixes and expanding abbreviations.

> diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSuite_buffer_scatter.py
> similarity index 99%
> rename from dts/tests/TestSuite_pmd_buffer_scatter.py
> rename to dts/tests/TestSuite_buffer_scatter.py
> index 96da67ee7d..539082f2e4 100644
> --- a/dts/tests/TestSuite_pmd_buffer_scatter.py
> +++ b/dts/tests/TestSuite_buffer_scatter.py
> @@ -35,7 +35,7 @@
>  
>  @requires_nic_capability(NicCapability.PHYSICAL_FUNCTION)
>  @requires_nic_capability(NicCapability.PORT_RX_OFFLOAD_SCATTER)
> -class TestPmdBufferScatter(TestSuite):
> +class TestBufferScatter(TestSuite):
>      """DPDK PMD packet scattering test suite.

Does the docstring need updating here? The class is now TestBufferScatter
but the docstring still mentions "DPDK PMD packet scattering test suite".
Should this be "DPDK packet scattering test suite" or "Buffer scatter
test suite" for consistency with the new naming?

[ ... ]

> diff --git a/dts/tests/TestSuite_rte_flow.py b/dts/tests/TestSuite_flow_offload.py
> similarity index 99%
> rename from dts/tests/TestSuite_rte_flow.py
> rename to dts/tests/TestSuite_flow_offload.py
> index 6255e4c36d..be11d09875 100644
> --- a/dts/tests/TestSuite_rte_flow.py
> +++ b/dts/tests/TestSuite_flow_offload.py
> @@ -402,8 +402,8 @@ def generate(
>  
>  
>  @requires_nic_capability(NicCapability.FLOW_CTRL)
> -class TestRteFlow(TestSuite):
> -    """RTE Flow test suite.
> +class TestFlowOffload(TestSuite):
> +    """Flow offload test suite.

Is "flow offload" an accurate description of what this test suite does?
The original name TestRteFlow and test description reference the rte_flow
API. Does renaming to "flow_offload" adequately convey that this tests
the rte_flow API functionality, or might this cause confusion with
hardware offload features more generally?

[ ... ]

> diff --git a/dts/tests/TestSuite_l2fwd.py b/dts/tests/TestSuite_l2_forward.py
> similarity index 98%
> rename from dts/tests/TestSuite_l2fwd.py
> rename to dts/tests/TestSuite_l2_forward.py
> index 596b892730..95f9c62bdc 100644
> --- a/dts/tests/TestSuite_l2fwd.py
> +++ b/dts/tests/TestSuite_l2_forward.py
> @@ -28,7 +28,7 @@
>  
>  @requires_nic_capability(NicCapability.PHYSICAL_FUNCTION)
>  @requires_link_topology(LinkTopology.TWO_LINKS)
> -class TestL2fwd(TestSuite):
> +class TestL2Forward(TestSuite):
>      """L2 forwarding test suite."""

[ ... ]

> diff --git a/dts/tests/TestSuite_pmd_rss.py b/dts/tests/TestSuite_rss.py
> similarity index 99%
> rename from dts/tests/TestSuite_pmd_rss.py
> rename to dts/tests/TestSuite_rss.py
> index f6adf262c3..2747c8a36c 100644
> --- a/dts/tests/TestSuite_pmd_rss.py
> +++ b/dts/tests/TestSuite_rss.py
> @@ -55,8 +55,8 @@ class HashAlgorithm(StrEnum):
>  
>  @requires_link_topology(LinkTopology.ONE_LINK)
>  @requires_nic_capability(NicCapability.PORT_RX_OFFLOAD_RSS_HASH)
> -class TestPmdRss(TestSuite):
> -    """PMD RSS test suite."""
> +class TestRss(TestSuite):
> +    """RSS test suite."""

[ ... ]

Overall, the patch is straightforward and primarily involves renaming test
suites and updating documentation references. The main question is whether
the docstring in TestBufferScatter needs updating to match the new class
name, and whether "flow_offload" is the most appropriate name for what was
previously the rte_flow test suite.