|SUCCESS| [v2,10/10] dts: add selective Rx tests

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163872

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-10

git sha: 20260509220356.3679114-2-thomas at monjalon.net
Author: Thomas Monjalon <thomas at monjalon.net>
Subject: [PATCH v2 01/10] app/testpmd: print Rx split capabilities

The patch adds code to print Rx split capabilities in the testpmd "show
port info" command by introducing a print_bool_capa helper function and
displaying several split-related fields.

> @@ -790,6 +790,12 @@ rss_offload_types_display(uint64_t offload_types, uint16_t char_num_per_line)
>  	printf("\n");
>  }
>  
> +static void
> +print_bool_capa(const char *label, int value)
> +{
> +	printf("%s: %s\n", label, value ? "supported" : "not supported");
> +}

Does this code properly handle the case where value might not be
strictly 0 or 1?

> +
>  void
>  port_infos_display(portid_t port_id)
>  {
> @@ -911,6 +917,16 @@ port_infos_display(portid_t port_id)
>  		dev_info.max_rx_pktlen);
>  	printf("Maximum configurable size of LRO aggregated packet: %u\n",
>  		dev_info.max_lro_pkt_size);
> +
> +	printf("Rx split:\n");
> +	printf("\tMax segments: %hu\n", dev_info.rx_seg_capa.max_nseg);
> +	if (dev_info.rx_seg_capa.max_nseg > 0) {
> +		print_bool_capa("\tMulti-pool", dev_info.rx_seg_capa.multi_pools);
> +		print_bool_capa("\tBuffer offset", dev_info.rx_seg_capa.offset_allowed);
> +		printf("\tOffset alignment: %u\n",
> +				RTE_BIT32(dev_info.rx_seg_capa.offset_align_log2));

Does this code overflow on offset_align_log2 >= 32?

> +		print_bool_capa("\tSelective Rx", dev_info.rx_seg_capa.selective_rx);

Can this code read selective_rx from uninitialized memory if max_nseg is
0 but the struct wasn't zeroed?

> +	}
> +
>  	if (dev_info.max_vfs)
>  		printf("Maximum number of VFs: %u\n", dev_info.max_vfs);
>  	if (dev_info.max_vmdq_pools)