|SUCCESS| [v4] dts: update test suite names to be clear and consistent
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Mon May 11 22:15:58 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163908
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-11
31a0e84f0c1d2b3a4e5f6g7h8i9j0k1l2m3n4o5p
Author: Andrew Bailey <abailey at iol.unh.edu>
Subject: [PATCH v4] dts: update test suite names to be clear and consistent
This patch renames several test suite files and classes to improve
naming consistency. It removes the "PMD" prefix from some test suites
and expands abbreviated words to their full forms.
> diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSuite_buffer_scatter.py
> similarity index 99%
> rename from dts/tests/TestSuite_pmd_buffer_scatter.py
> rename to dts/tests/TestSuite_buffer_scatter.py
> index 96da67ee7d..539082f2e4 100644
> --- a/dts/tests/TestSuite_pmd_buffer_scatter.py
> +++ b/dts/tests/TestSuite_buffer_scatter.py
> @@ -35,7 +35,7 @@
>
> @requires_nic_capability(NicCapability.PHYSICAL_FUNCTION)
> @requires_nic_capability(NicCapability.PORT_RX_OFFLOAD_SCATTER)
> -class TestPmdBufferScatter(TestSuite):
> +class TestBufferScatter(TestSuite):
> """DPDK PMD packet scattering test suite.
>
> Configure the Rx queues to have mbuf data buffers
Does the class docstring need updating? It still refers to "DPDK PMD
packet scattering test suite" but the class is now named TestBufferScatter
without the PMD prefix.
[ ... ]
> diff --git a/dts/tests/TestSuite_rte_flow.py b/dts/tests/TestSuite_flow_offload.py
> similarity index 99%
> rename from dts/tests/TestSuite_rte_flow.py
> rename to dts/tests/TestSuite_flow_offload.py
> index 6255e4c36d..be11d09875 100644
> --- a/dts/tests/TestSuite_rte_flow.py
> +++ b/dts/tests/TestSuite_flow_offload.py
> @@ -402,8 +402,8 @@ def generate(
>
>
> @requires_nic_capability(NicCapability.FLOW_CTRL)
> -class TestRteFlow(TestSuite):
> - """RTE Flow test suite.
> +class TestFlowOffload(TestSuite):
> + """Flow offload test suite.
Does renaming TestRteFlow to TestFlowOffload accurately reflect what the
suite tests? The original name specifically referenced RTE Flow, which is
a DPDK API. Is "flow offload" the same concept, or does it introduce
ambiguity about whether this tests hardware offload or the RTE Flow API?
[ ... ]
> diff --git a/dts/tests/TestSuite_pmd_rss.py b/dts/tests/TestSuite_rss.py
> similarity index 99%
> rename from dts/tests/TestSuite_pmd_rss.py
> rename to dts/tests/TestSuite_rss.py
> index f6adf262c3..2747c8a36c 100644
> --- a/dts/tests/TestSuite_pmd_rss.py
> +++ b/dts/tests/TestSuite_rss.py
> @@ -55,8 +55,8 @@ class HashAlgorithm(StrEnum):
>
> @requires_link_topology(LinkTopology.ONE_LINK)
> @requires_nic_capability(NicCapability.PORT_RX_OFFLOAD_RSS_HASH)
> -class TestPmdRss(TestSuite):
> - """PMD RSS test suite."""
> +class TestRss(TestSuite):
> + """RSS test suite."""
The docstring change seems reasonable here.
[ ... ]
More information about the test-report
mailing list