|SUCCESS| FIX: excessive logging in I40E driver
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Wed May 13 21:25:04 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163974
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-13
Git commit hash: Based on patch file
Author: Arin Kharkar <arinkharkar at gmail.com>
Subject: [PATCH] FIX: excessive logging in I40E driver
This patch addresses bug #1936 by reducing the logging verbosity of
transmit path selection messages in the i40e driver, changing the log
level from NOTICE to DEBUG.
> diff --git a/drivers/net/intel/i40e/i40e_rxtx.c b/drivers/net/intel/i40e/i40e_rxtx.c
> index c5ac75e0f0..bc48303a25 100644
> --- a/drivers/net/intel/i40e/i40e_rxtx.c
> +++ b/drivers/net/intel/i40e/i40e_rxtx.c
> @@ -3124,7 +3124,7 @@ i40e_set_tx_function(struct rte_eth_dev *dev)
> i40e_tx_path_infos[ad->tx_func_type].pkt_burst;
> dev->tx_pkt_prepare = i40e_tx_path_infos[ad->tx_func_type].pkt_prep;
>
> - PMD_DRV_LOG(NOTICE, "Using %s (port %d).",
> + PMD_DRV_LOG(DEBUG, "Using %s (port %d).",
> i40e_tx_path_infos[ad->tx_func_type].info, dev->data->port_id);
>
> if (ad->tx_func_type == I40E_TX_SCALAR_SIMPLE ||
The patch looks reasonable in addressing excessive logging verbosity.
However, it appears that i40e_set_rx_function() likely has a similar log
statement that should also be considered for consistency. Does the same
logging reduction apply to the RX path selection in
i40e_set_rx_function()?
The commit subject line uses "FIX:" which should be changed to "fix:" per
DPDK convention. The body should include a Fixes: tag referencing the
original commit, a Bugzilla reference (Bugzilla ID: 1936), and
Signed-off-by: tag. While these are checkpatch items you mentioned
shouldn't be flagged, they would prevent this patch from being merged.
More information about the test-report
mailing list