|SUCCESS| Remove redundant simpler equivalent section
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Wed May 13 21:51:41 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/163972
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-13
commit 82a93b4c1e8f9d2a7e1f0b6d3c5a8e9f7d2b4c6a
Author: Arin Kharkar <arinkharkar at gmail.com>
Subject: Remove redundant simpler equivalent section
This patch removes outdated documentation that incorrectly described an
alternative way to launch the lcore_hello function. The example program
already uses the simpler version, making the documentation note about a
"simpler equivalent" redundant.
> diff --git a/doc/guides/sample_app_ug/hello_world.rst b/doc/guides/sample_app_ug/hello_world.rst
> index 5bfd4b3fda..b7167aa345 100644
> --- a/doc/guides/sample_app_ug/hello_world.rst
> +++ b/doc/guides/sample_app_ug/hello_world.rst
> @@ -70,12 +70,4 @@ The code that launches the function on each lcore is as follows:
> :end-before: >8 End of launching the function on each lcore.
> :dedent: 1
>
> -The following code is equivalent and simpler:
> -
> -.. literalinclude:: ../../../examples/helloworld/main.c
> - :language: c
> - :start-after: Simpler equivalent. 8<
> - :end-before: >8 End of simpler equivalent.
> - :dedent: 2
> -
> Refer to the *DPDK API Reference* for detailed information on the rte_eal_mp_remote_launch() function.
[ ... ]
> diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c
> index af509138da..8d1a959c58 100644
> --- a/examples/helloworld/main.c
> +++ b/examples/helloworld/main.c
[ ... ]
> @@ -40,13 +40,11 @@ main(int argc, char **argv)
>
> /* Launches the function on each lcore. 8< */
> RTE_LCORE_FOREACH_WORKER(lcore_id) {
> - /* Simpler equivalent. 8< */
> rte_eal_remote_launch(lcore_hello, NULL, lcore_id);
> - /* >8 End of simpler equivalent. */
> }
>
> /* call it on main lcore too */
> - lcore_hello(NULL);
> + lcore_hello(NULL);
Does this change introduce a leading whitespace alignment issue? The
added space before lcore_hello() appears to be a tab followed by a space
rather than a single tab, creating inconsistent indentation with the
surrounding code.
More information about the test-report
mailing list