|WARNING| pw164209 [PATCH 09/10] net/e1000/base: auto-negotiation status for 1000BASE-T

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/164209

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct e1000_hw *' should also have an identifier name
#205: FILE: drivers/net/intel/e1000/base/e1000_hw.h:814:
+	s32  (*get_an_status)(struct e1000_hw *, u8 *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u8 *' should also have an identifier name
#205: FILE: drivers/net/intel/e1000/base/e1000_hw.h:814:
+	s32  (*get_an_status)(struct e1000_hw *, u8 *);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#230: FILE: drivers/net/intel/e1000/base/e1000_phy.c:142:
+s32 e1000_null_an_status(struct e1000_hw E1000_UNUSEDARG *hw,
                                                          ^

WARNING:TYPO_SPELLING: 'ANE' may be misspelled - perhaps 'AND'?
#253: FILE: drivers/net/intel/e1000/base/e1000_phy.c:2452:
+ *  the data from PHY Status (PSTATUS) and Auto–Negotiation Expansion (ANE)
                                                                        ^^^

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'e1000_1gbase_t_autoneg_status', this function's name, in a string
#265: FILE: drivers/net/intel/e1000/base/e1000_phy.c:2464:
+	DEBUGFUNC("e1000_1gbase_t_autoneg_status
");

WARNING:TYPO_SPELLING: 'ANE' may be misspelled - perhaps 'AND'?
#292: FILE: drivers/net/intel/e1000/base/e1000_phy.c:2491:
+			DEBUGOUT1("Reading PHY ANE register returned error: %X
", ret_val);
 			                       ^^^

total: 0 errors, 5 warnings, 1 checks, 205 lines checked