|WARNING| pw164272 [PATCH v4 02/26] net/intel/common: add common flow action parsing

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/164272

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'qnum == 0'
#234: FILE: drivers/net/intel/common/flow_check.h:134:
+	if ((qnum == 0) != (rss->queue == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rss->queue == NULL'
#234: FILE: drivers/net/intel/common/flow_check.h:134:
+	if ((qnum == 0) != (rss->queue == NULL)) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#256: FILE: drivers/net/intel/common/flow_check.h:156:
+	if (param != NULL && param->rss_queues_contig) {
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rss->key_len == 0'
#260: FILE: drivers/net/intel/common/flow_check.h:160:
+	if ((rss->key_len == 0) != (rss->key == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'rss->key == NULL'
#260: FILE: drivers/net/intel/common/flow_check.h:160:
+	if ((rss->key_len == 0) != (rss->key == NULL)) {

WARNING:MACRO_ARG_UNUSED: Argument 'level' is not used in function-like macro
#408: FILE: drivers/net/intel/common/log.h:24:
+#define CI_DRV_LOG(level, fmt, ...) do { } while (0)

WARNING:MACRO_ARG_UNUSED: Argument 'fmt' is not used in function-like macro
#408: FILE: drivers/net/intel/common/log.h:24:
+#define CI_DRV_LOG(level, fmt, ...) do { } while (0)

total: 0 errors, 3 warnings, 4 checks, 318 lines checked
Warning in drivers/net/intel/common/log.h:
Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE