|SUCCESS| [V2,1/1] net/hinic3: Fix VXLAN TSO issue

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/164299

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-05-23

I'll review this patch for compliance with DPDK coding standards and contribution guidelines.

git sha: Not available in patch
Author: Feifei Wang <wangfeifei40 at huawei.com>
Subject: net/hinic3: Fix VXLAN TSO issue

Brief summary: This patch adds the RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag to
the device capabilities in hinic3_dev_infos_get() to properly advertise VXLAN
TSO support.

> diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c
> index f4eb788..fbadb1e 100644
> --- a/drivers/net/hinic3/hinic3_ethdev.c
> +++ b/drivers/net/hinic3/hinic3_ethdev.c
> @@ -696,7 +696,7 @@ hinic3_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)
>  		RTE_ETH_TX_OFFLOAD_VLAN_INSERT | RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
>  		RTE_ETH_TX_OFFLOAD_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
>  		RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> -		RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> +		RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
>  		RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS;

Does the code that follows at line 699 (hinic3_dev_tnl_tso_support()) already
handle VXLAN TSO capability detection? If the function at line 699
conditionally adds tunnel TSO flags based on hardware capabilities, does
unconditionally adding RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO at line 699 create a
conflict where the capability is advertised even when the hardware doesn't
support it?

Can this line exceed 80 characters? The coding style guide requires lines to
not exceed 80 characters. The modified line appears to potentially exceed this
limit with the addition of RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO. Should this be
reformatted to multiple lines or does it fit within the 80 character limit?