|WARNING| [2/2] acl: inline the match checks into the RVV search loops

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172326

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-01

I've reviewed this 2-patch series against the DPDK AGENTS.md guidelines. Here is my analysis:

---

## Patch 1/2: eal: add flatten function attribute

### Code Style

**Error - Missing blank line between declarations and statements:**
The new macro definition in `rte_common.h` lacks separation. The pattern should be:
- Doxygen comment
- Blank line
- Macro definition

Currently:
```c
/**
 * Inline every call made by a function into it...
 */
#ifdef RTE_TOOLCHAIN_MSVC
```

Should be:
```c
/**
 * Inline every call made by a function into it...
 */

#ifdef RTE_TOOLCHAIN_MSVC
```

This follows the existing pattern in the file (see `__rte_noinline` definition above).

### Documentation

**Warning - Missing release notes:**
This patch introduces new public API (`__rte_flatten` macro in an installed header). Per AGENTS.md:
- "New API functions must be marked as `__rte_experimental`" (not directly applicable to macros, but the principle applies)
- "Changes to existing API require release notes"
- "New drivers or subsystems must have release notes"

The current release notes file should be updated to document this new macro under "New Features" or "API Changes".

---

## Patch 2/2: acl: inline the match checks into the RVV search loops

### Code Style

**Info - Comment style inconsistency:**
The multi-line comment added:
```c
/*
 * Execute trie traversal with 8 traversals in parallel.
 * Flattened: a vector value live across a call is spilled, and the
 * frame is then addressed through vlenb.
 */
```

Uses correct DPDK multi-line comment format and is consistent with the function below it at line 274. No issue.

### Pre-existing Code (Info only)

The existing comment at line 273:
```c
/*
 * Execute trie traversal with 4 traversals in parallel
 */
```

Missing trailing period, inconsistent with the updated comment above it. This is pre-existing and not introduced by this patch, but worth noting for cleanup in a separate patch.

---

## Overall Assessment

The patches implement a focused optimization for RISC-V vector (RVV) code paths by introducing `__rte_flatten` and applying it to avoid costly function call overhead where vector register spilling is expensive. The technical approach is sound.

**Issues found:**
1. **Error:** Missing blank line in patch 1 between Doxygen and macro definition
2. **Warning:** Missing release notes entry for the new `__rte_flatten` macro

**Correctness:** No bugs identified. The `__rte_flatten` attribute is correctly conditioned on toolchain (MSVC doesn't support it), and its application to the search functions is appropriate for the stated goal.

**Style compliance:** Generally good, with the one formatting error noted above.

---

Review-Result: ERROR