|WARNING| net/mlx5: fix local and host representor name collision

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172348

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-02

# DPDK Patch Review

## Patch Summary
This patch fixes a naming collision between local and host representors on BlueField by adding controller and PF indexes to local representor names when a host PF is present.

---

## ERRORS

None identified.

---

## WARNINGS

### 1. Missing release notes update

**File:** drivers/net/mlx5/linux/mlx5_os.c  
**Issue:** This patch fixes a bug that changes user-visible port naming and adds a new log message, but does not update the release notes.

**Why it matters:** The naming change affects applications that rely on port name patterns. Users upgrading to this version need to know that local representor names will change from `<BDF>_representor_vf0` to `<BDF>_representor_c0pf0vf0` on BlueField systems with host PFs.

**Suggested fix:** Add an entry to `doc/guides/rel_notes/release_26_11.rst` (or current release) under "Bug Fixes" section:

```rst
* **net/mlx5: Fixed local and host representor name collision on BlueField.**

  On BlueField with a single uplink and host PF, local representors (controller 0)
  and host representors (controller 1) with the same index previously had the same
  name, causing probing failures. Local representor names now include controller
  and PF indexes (e.g., ``<BDF>_representor_c0pf0vf0``) when a host PF is present.
```

---

## INFO

### 1. Consider bounds check on controller and PF numbers

**File:** drivers/net/mlx5/linux/mlx5_os.c  
**Line:** `spawn->info.ctrl_num` and `spawn->info.pf_num` in `snprintf()`

The controller and PF numbers come from the device information structure. While these are likely bounded by hardware constraints, an explicit bounds check before formatting could prevent potential buffer issues if the fields ever contain unexpected values. This is a hardening suggestion for robustness, not a correctness bug in the current code.

### 2. Log message uses DRV_LOG(NOTICE)

**File:** drivers/net/mlx5/linux/mlx5_os.c  
**Line 1370-1371:**
```c
DRV_LOG(NOTICE, "representor \"%s\" is already spawned as port %u",
        name, port_id);
```

This is acceptable. The NOTICE level is appropriate for informing the user that a representor probe was a no-op because the port already exists. The message provides useful diagnostic information without being an error or warning.

---

Review-Result: WARNING