|SUCCESS| [v2] net/ice: add explicit control of link auto-negotiation

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172350

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-02

# DPDK Patch Review

## Patch: net/ice: add explicit control of link auto-negotiation

### ERRORS

None identified.

### WARNINGS

None identified.

### INFO

**Documentation suggestion:**

In `doc/guides/nics/ice.rst`, the new `auto_neg_disable` option is inserted before the existing "Safe Mode Support" option without a separating blank line. The existing runtime configuration items appear to use different formatting conventions. Consider ensuring consistent spacing between runtime configuration option entries for readability.

**Devarg initialization:**

The new field `auto_neg_disable` in `struct ice_devargs` will be zero-initialized when the structure is allocated (via the parent `struct ice_pf` or `struct ice_adapter`). This is correct for the default behavior (auto-negotiation enabled). The code is safe.

**Boolean usage:**

The patch correctly uses `bool` type for the new `auto_neg_disable` field and the helper function `ice_link_autoneg_enabled()` returns `bool`. This follows the guideline for true/false values.

**Function naming:**

The new helper function `ice_link_autoneg_enabled()` follows the appropriate naming convention (lowercase with underscores, predicate function with `is_*`/`has_*`/`enabled` pattern).

**Error path handling:**

In `ice_parse_devargs()`, the new `rte_kvargs_process()` call correctly propagates errors via the `ret` variable and jumps to the `bail:` label for cleanup. The resource management is correct.

**Testpmd/functional tests:**

This patch adds a new driver-specific devarg (`auto_neg_disable`). Driver devargs typically do not require testpmd hooks, as they are configuration parameters rather than runtime control features. The documentation provides a usage example with the `-a` option, which is the standard way to test devargs.

**Release notes:**

The patch correctly updates the current release notes file (`release_26_11.rst`) under "Updated Intel ice driver." The description is clear and matches the code changes.

Review-Result: CLEAN