|WARNING| [v2] net/ice: add explicit control of link auto-negotiation

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172350

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-02

# DPDK Patch Review

## ERRORS

None identified.

## WARNINGS

**Missing release notes update for API behavior change:**

The patch changes the default behavior of fixed-speed link configuration. Previously, auto-negotiation was always disabled for `RTE_ETH_LINK_SPEED_FIXED` (per commit 3dc2933866d9). Now, the firmware's negotiation settings are preserved by default unless `auto_neg_disable=1` is set.

This is a behavior change that affects existing users who were relying on the previous "auto-negotiation disabled" default. While the release notes mention the new devarg, they should explicitly state that the default behavior for fixed-speed links has changed to preserve firmware negotiation settings.

**Suggested addition to release notes:**

```rst
* **Updated Intel ice driver.**

  * Changed default behavior for fixed-speed link configuration: firmware negotiation
    settings are now preserved by default. Use ``auto_neg_disable=1`` to restore the
    previous behavior of disabling Clause 28, Clause 37, and Clause 73 negotiation.
  * Added ``auto_neg_disable`` devarg to explicitly control hardware link negotiation
    for fixed-speed links.
```

**Location:** `doc/guides/rel_notes/release_26_11.rst` lines 178-179

## INFO

**Documentation clarity:**

The RST documentation under "Runtime Configuration" uses a simple bullet list for the devarg description, but the existing "Safe Mode Support" entry below it follows a different format (dash-prefixed). For consistency within this section, consider using the dash-prefix format that matches the existing "Safe Mode Support" entry.

Review-Result: WARNING