|WARNING| ethdev: add 1.6T link speed
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Tue Nov 3 14:50:16 CET 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172371
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-03
# DPDK Patch Review
## Errors
None identified.
## Warnings
**Missing release notes for user-visible feature addition (Warning)**
The patch adds a new link speed definition (`RTE_ETH_LINK_SPEED_1600G`), which is a user-visible API addition that requires release notes documentation. However, the release notes entry in `doc/guides/rel_notes/release_26_11.rst` does not mention that this is a new API addition or experimental feature.
**Suggested fix:**
The release notes section should explicitly state this is an API addition:
```rst
* **Added 1.6 Tbps link speed to ethdev.**
Added ``RTE_ETH_LINK_SPEED_1600G`` and ``RTE_ETH_SPEED_NUM_1600G``
definitions to ethdev, allowing representation of 1.6 Tbps Ethernet
links in accordance with the IEEE P802.3dj standardization effort.
```
**New public API symbols missing experimental marking (Warning)**
The patch adds new public API definitions (`RTE_ETH_LINK_SPEED_1600G` and `RTE_ETH_SPEED_NUM_1600G`) to the stable API in `lib/ethdev/rte_ethdev.h` without marking them as experimental. New API additions should typically be marked as `__rte_experimental` initially.
**Suggested fix:**
Mark the new definitions as experimental:
```c
/**
* 800 Gbps is standardized in IEEE 802.3df; IEEE P802.3dj is
* standardizing 1.6 Tbps as the next rate.
*/
__rte_experimental
#define RTE_ETH_LINK_SPEED_1600G RTE_BIT32(18) /**< 1.6 Tbps */
```
And similarly for `RTE_ETH_SPEED_NUM_1600G`.
Note: If the maintainers decide this should be stable API from the start given the ongoing IEEE standardization, this warning can be disregarded, but the decision should be explicit.
## Info
None.
---
Review-Result: WARNING
More information about the test-report
mailing list