|SUCCESS| ethdev: add 1.6T link speed
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Tue Nov 3 16:22:59 CET 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172371
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-03
# DPDK Patch Review
## Summary
This patch adds 1.6 Tbps Ethernet link speed support to the ethdev API. The changes are straightforward additions to existing speed enumeration tables across testpmd, drivers, tests, and documentation.
## Review
### Code Quality
The patch is well-structured and consistent. All additions follow the existing pattern for speed definitions. The code changes are mechanical and appropriately cover all locations where speed values are handled.
### Documentation
Release notes are properly updated and include appropriate context about IEEE 802.3df (800G) and IEEE P802.3dj (1.6T standardization). The comment in `rte_ethdev.h` explaining the standards progression is a helpful addition.
### Testing
The test suite (`test_ethdev_link.c`) is updated to include the new speed value, ensuring the new constant is exercised. The test correctly uses `RTE_ETH_SPEED_NUM_1600G` in both the max string length test and the speed-to-string conversion test.
### API Changes
The new speed definitions are added to the stable API (`rte_ethdev.h`). This is an additive change that does not break ABI compatibility--new enum/constant values are acceptable additions. Release notes correctly document this as a new feature.
### Observations
1. The patch updates all the right places: command-line parsing, help text, info display, telemetry, link speed conversion functions, and tests.
2. The virtio driver's `virtio_dev_speed_capa_get()` function is updated to handle the new speed, maintaining consistency across drivers.
3. The formatting "1.6 Tbps" in display strings is consistent with how lower speeds are displayed (e.g., "800 Gbps").
4. All numeric constants and their corresponding bit flags are properly paired.
---
Review-Result: CLEAN
More information about the test-report
mailing list