|SUCCESS| app/test-pmd: add explicit parameter for fixed link speeds

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172601

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-03

# DPDK Patch Review

## ERRORS

None identified.

## WARNINGS

None identified.

## INFO

### Minor Documentation Clarity

The release notes entry could be slightly more precise. The text says:

> Numeric speeds now leave link autonegotiation enabled unless ``fixed`` is specified.

This is somewhat misleading because the old behavior always set `RTE_ETH_LINK_SPEED_FIXED` when a numeric speed was given. The change is that now numeric speeds *without* the `fixed` keyword do NOT set that flag, enabling autonegotiation. Consider rephrasing to:

> Previously, numeric speeds always disabled autonegotiation. Now, numeric speeds enable autonegotiation unless the ``fixed`` keyword is specified.

This is clearer about what changed.

### Code Quality Observations

**Good practices observed:**
- Proper error checking for invalid combinations (`fixed` with `auto` speed)
- Consistent pattern for both "all" and specific port commands
- Clear help text in command definitions
- Release notes and user guide documentation updated atomically with code
- Boolean parameter (`fixed`) passed via `data` pointer is a clean approach

**Command parsing approach:**
The use of the `data` pointer to pass the `fixed` flag (non-NULL means fixed) is acceptable for this context. The pattern `data != NULL` as a boolean is used correctly.

The code correctly rejects `fixed` with `auto` speed:
```c
if (fixed) {
    if (*speed == RTE_ETH_LINK_SPEED_AUTONEG) {
        fprintf(stderr, "A fixed link requires a specific speed\n");
        return -1;
    }
    *speed |= RTE_ETH_LINK_SPEED_FIXED;
}
```

**Style conformance:**
- Indentation and formatting appear correct
- Error messages appropriately use `stderr`
- Function signatures follow DPDK style (return type on own line)
- Token definitions follow existing patterns

---

Review-Result: CLEAN