|WARNING| ipc: increase hotplug devargs limit

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172603

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-03

# DPDK Patch Review

## ERRORS

None.

## WARNINGS

### 1. Incorrect format specifier in error message (line 279)

**Issue:** The error message uses `%d` for `EAL_DEV_MP_DEV_ARGS_MAX_LEN` which is now a `size_t` expression (result of `sizeof`), but the patch changes it to `%zu`. However, looking at the changed line again:

```c
-		EAL_LOG(ERR, "devargs truncated (len %zu, max %d)",
+		EAL_LOG(ERR, "devargs truncated (len %zu, max %zu)",
```

This is actually **correct** - the change from `%d` to `%zu` is appropriate since `EAL_DEV_MP_DEV_ARGS_MAX_LEN` is now defined as an expression involving `sizeof()` operations which yield `size_t`. This change is needed and correct.

**Correction:** This is not an issue - the format specifier change is correct.

### 2. Missing release notes update

**Issue:** This patch changes the maximum devargs length from 127 to 247 bytes, which is a user-visible behavioral change that applications might depend on. The release notes should document this increase in capacity.

**Suggested fix:** Add an entry to `doc/guides/rel_notes/release_XX_YY.rst` under an appropriate section (e.g., "New Features" or "API Changes"):

```rst
* **Increased hotplug devargs limit in multi-process mode.**

  The maximum device arguments string length for hotplug operations
  in multi-process mode has been increased from 127 to 247 bytes
  (excluding the terminating null byte).
```

## INFO

### 1. Comment formatting - missing spaces

The comment on lines 16-17:

```c
	/* minus t and result from struct eal_dev_mp_req */
```

The comment refers to "t and result" but field names are `enum eal_dev_req_type t` and `int result`. For clarity, consider:

```c
	/* minus enum eal_dev_req_type and int result */
```

This is a minor clarity improvement, not a requirement.

### 2. Verification of arithmetic

The new definition:
```c
#define EAL_DEV_MP_DEV_ARGS_MAX_LEN (RTE_MP_MAX_PARAM_LEN \
	- sizeof(enum eal_dev_req_type) - sizeof(int))
```

This correctly accounts for the `t` and `result` fields in `struct eal_dev_mp_req`, leaving the remainder for the `devargs` character array. The `static_assert` on line 33 validates that the entire structure fits within `RTE_MP_MAX_PARAM_LEN`. The arithmetic is sound.

### 3. Positive observation - good use of static_assert

The addition of the `static_assert` on lines 33-34 is excellent practice - it ensures at compile time that the structure size constraint is maintained, preventing future changes from inadvertently breaking the IPC parameter size limit.

Review-Result: WARNING