|WARNING| [v1, 1/1] net/iavf: allow flow validation without engine callback

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172637

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-04

# DPDK Patch Review

## Errors

None identified.

## Warnings

### Missing release notes (Warning)
This patch fixes a bug in existing API behavior (flow validation) which affects driver functionality. This is a user-visible change that should be documented in the release notes under the "Fixed Issues" section for the iavf PMD.

**Suggested fix:**
Add an entry to `doc/guides/rel_notes/release_26_03.rst` (or the appropriate current release notes file) under a "Fixed Issues" section:

```rst
* **net/iavf: Fixed flow validation for engines without validation callbacks.**

  Fixed an issue where flow validation would incorrectly fail for engines
  that successfully parse patterns and actions but do not provide a
  validation callback.
```

## Info

### Code correctness - verified clean
The patch correctly:
- Preserves the existing error paths (parsing failures still propagate)
- Only skips the validation callback when `engine->validation == NULL`
- Continues to call the validation callback when it exists
- Maintains proper resource cleanup (`rte_free(meta)` after validation regardless of callback presence)
- Returns 0 (success) when parsing succeeds and no validation callback exists

### Logic improvement
The change is consistent with the principle that successful parsing should be sufficient for validation when no additional validation logic is provided by the engine. The original code treated missing validation callbacks as an error, which was overly restrictive.

Review-Result: WARNING