|WARNING| [v2,3/3] build: deprecate HPET support

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172646

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-06

# DPDK Patch Review

## Patch 1/3: build: deprecate kernel dir option

### Errors
None.

### Warnings
None.

### Info
None.

---

## Patch 2/3: build: deprecate standalone tests option

### Errors
None.

### Warnings

**app/meson.build line +20**
```c
        'test',
```
The patch moves `'test'` into the unconditional `apps` list but does not verify whether the existing `get_option('tests')` conditional logic is fully removed. If `get_option('tests')` is now ignored and 'test' is always built unless disabled via `disable_apps`, this could be a silent behavior change for users relying on `-Dtests=false`.

The deprecation notice says "Add 'tests' to disable_apps setting to disable the unit tests" but the code change makes tests always included by default. Users who previously set `-Dtests=false` will now get tests built unless they also add `tests` to `disable_apps`. This is a breaking change without a migration path documented in the release notes beyond the deprecation notice.

**meson_options.txt line +58**
```
       '[Deprecated] Value unused. Add "tests" to disable_apps setting to disable the unit tests')
```
The description says "Value unused" but the code in `app/meson.build` still respects `get_option('tests')` in v1. If the value is truly unused after this patch, verify that no other meson.build files or scripts check this option. The deprecation message should clarify the transition: "Setting this to false is deprecated; to disable tests, add 'tests' to the disable_apps option instead."

---

## Patch 3/3: build: deprecate HPET support

### Errors
None.

### Warnings
None.

### Info
None.

---

## General Comments

- The series consistently documents deprecations in `doc/guides/rel_notes/deprecation.rst` as required.
- All three patches correctly update only the current release notes file (not versioned release notes).
- No correctness bugs identified (no code logic is changed, only build options and documentation).
- The patches are purely deprecation notices and documentation cleanup, appropriate for the main development branch.

**Final severity assessment:**
- Patch 1: Clean
- Patch 2: Has warnings about the behavioral change and migration path
- Patch 3: Clean

Review-Result: WARNING