|SUCCESS| net/ice: fix NULL dereference on ACL init failure
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Nov 6 08:25:59 CET 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172689
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-06
# Review of PATCH: net/ice: fix NULL dereference on ACL init failure
## ERRORS
None.
## WARNINGS
None.
## INFO
This patch correctly addresses a NULL pointer dereference bug in the error path.
**Analysis:**
The patch adds a NULL check in `ice_acl_prof_free()` before dereferencing `hw->acl_prof`. This prevents a crash when:
1. `ice_acl_init()` fails to allocate `hw->acl_prof` (leaving it NULL)
2. `ice_flow_init()` subsequently fails
3. `ice_dev_init()` calls `ice_flow_uninit()`
4. `ice_flow_uninit()` calls `ice_acl_prof_free()` which would dereference the NULL pointer
The fix is minimal, correct, and follows the pattern of defensive programming for cleanup functions that may be called after partial initialization failure.
**Code quality:**
- The explicit NULL comparison (`hw->acl_prof == NULL`) follows DPDK style requirements
- Early return pattern is appropriate for error handling
- The fix is in the correct location (the cleanup function rather than attempting to prevent the call)
**Cc: stable at dpdk.org is appropriate** given this fixes a crash on an error path that could occur in production deployments.
Review-Result: CLEAN
More information about the test-report
mailing list