|SUCCESS| test: add CRC length and alignment sweep

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172729

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-08

# DPDK Patch Review

## Analysis

This patch adds a comprehensive length sweep test for CRC implementations and fixes a missing error accumulation in test 4.

### Pass 1: Correctness Bugs

No correctness bugs identified. The patch properly:
- Allocates stack buffer of adequate size (512 + 8 bytes)
- Uses `rte_rand()` appropriately for test data generation
- Correctly pairs every `rte_net_crc_set_alg()` with `rte_net_crc_free()`
- Properly propagates test failures via return value
- Accumulates the missing test 4 result

### Pass 2: Style and Process Review

**Errors**

1. **Implicit comparison in conditional** (line 129):
```c
if (rte_net_crc_calc(ctx, buf + off, len) !=
        rte_net_crc_calc(ref, buf + off, len)) {
```
DPDK style requires explicit comparison against zero for integer return values. However, `rte_net_crc_calc()` returns a CRC value (uint32_t or uint16_t depending on type), not a boolean or error code, so direct comparison between two CRC values is correct here. This is not an error.

**After review: No style errors.**

### Pass 3: Evidence Check

All observations above are based on lines present in the patch:
- Line 115-116: `uint8_t buf[512 + 8];` (stack allocation)
- Line 118-119: `buf[i] = rte_rand();` (initialization)
- Line 121-123: `rte_net_crc_set_alg()` calls
- Line 129-130: CRC comparison
- Line 134, 137, 139: `rte_net_crc_free()` calls ensuring cleanup
- Line 172: Missing `ret |=` added for test 4

## Findings

**Info**

The test exercises lengths 0-512 bytes with offsets 0-7, which provides good coverage of:
- Different alignment scenarios (offset sweep)
- Vector processing boundaries (length sweep including edge cases)
- Both CRC16 and CRC32 implementations

This is a valuable addition to the test suite.

Review-Result: CLEAN