|SUCCESS| net/mlx5: fix external egress group translation

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172738

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-09

# DPDK Patch Review

## Analysis

This patch modifies the group translation logic in `drivers/net/mlx5/mlx5_flow_hw.c`.
The change removes a condition from the external egress group shift logic
that previously gated the shift on `dv_xmeta_en == MLX5_XMETA_MODE_META32_HWS`.

**Code change summary:**
- Line 5593: Removes `config->dv_xmeta_en == MLX5_XMETA_MODE_META32_HWS &&` condition
- Lines 5600-5604: Updates comment to reflect that representor matching is always enabled
- The net effect: external egress groups are now shifted when `dv_esw_en` is enabled,
  regardless of the `dv_xmeta_en` setting

**Reviewed code path:**
The changed lines are part of the `__translate_group()` function.
The patch removes a condition from a conditional block that increments `group`
to avoid collision with the reserved group 0.

## ERRORS

None.

## WARNINGS

None.

## INFO

**1. Consider verifying the full impact of the condition removal**

The patch removes the `dv_xmeta_en == MLX5_XMETA_MODE_META32_HWS` check,
which means the group shift now applies to all metadata modes when E-Switch is enabled.
The commit message states this "restores the previous repr_matching_en=1 behavior",
but reviewers should verify that all metadata modes are compatible with this shift
(XMETA_MODE_LEGACY, XMETA_MODE_META16, etc.).

Note: This is an Info observation, not a defect.
The patch author and acker appear to have validated this change.

Review-Result: CLEAN