|SUCCESS| net: fix tunnel parsing of non-IP packets

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Mon Nov 9 15:52:27 CET 2026


Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172744

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-09

# DPDK Patch Review

## ERRORS

None identified.

## WARNINGS

None identified.

## INFO

**Correctness improvement:**
The patch correctly fixes a packet type parsing bug where non-IP EtherTypes were being misinterpreted as IP protocol numbers on little-endian systems, causing incorrect tunnel detection. The fix appropriately returns early when the packet is not IPv4 or IPv6, preventing the subsequent tunnel parsing logic from operating on invalid data.

The logic flow is now:
1. If IPv4 or IPv6, parse L3/L4 and potentially tunnels
2. If neither, return immediately with L2 ptype only

This prevents the comparison in `ptype_tunnel_without_udp()` between EtherType values (network byte order, 16-bit) and IP protocol numbers (8-bit), which was the root cause of false positive tunnel detection.

**Note:** The patch is correctly targeted at fixing a correctness bug in existing code. The Fixes tag and stable at dpdk.org Cc are appropriate.

Review-Result: CLEAN


More information about the test-report mailing list