|SUCCESS| [v2] net/af_packet: fix build with old kernel headers
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Mon Nov 9 17:27:45 CET 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172751
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-09
# DPDK Patch Review
## ERRORS
None.
## WARNINGS
None.
## INFO
**Documentation prerequisite formatting**
The documentation adds a bullet point about kernel header requirements.
For consistency with the existing "Prerequisites" section style,
the new bullet could omit the version parenthetical in the main text
and move it to a note or separate sentence if needed.
However, the current format is clear and acceptable.
**Meson check ordering**
The patch adds a second `subdir_done()` after the Linux platform check.
Both checks are mutually exclusive (either is sufficient to skip the driver),
so combining them into a single conditional or ensuring the second check
only runs when needed is a minor optimization.
The current structure is correct and explicit.
**Symbol check method**
Using `cc.has_header_symbol()` is the correct approach for detecting
compile-time constants in headers.
The check is appropriate and follows DPDK meson patterns.
---
**Summary:**
This patch correctly addresses a build failure on older kernel headers
by detecting the missing `PACKET_IGNORE_OUTGOING` symbol at configure time
and skipping the driver when unavailable.
The approach is sound and matches DPDK's handling of platform-specific requirements.
No correctness bugs, style violations, or API issues identified.
Review-Result: CLEAN
More information about the test-report
mailing list