|SUCCESS| examples/qos_sched: fix build with LTO
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Tue Nov 10 03:42:54 CET 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172788
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-11-10
# DPDK Patch Review
## Errors
None identified.
## Warnings
None identified.
## Info
**1. Missing release notes**
The patch fixes a build issue (LTO failure) which is a user-visible improvement. Consider documenting this in `doc/guides/rel_notes/release_*.rst` under "Fixed Issues" or a similar section. While test/example-only changes typically do not require release notes, build fixes that unblock a compiler feature or flag may be worth mentioning for users encountering the same issue.
**2. Variable-length array bounds check pattern**
The fix correctly validates `n_entries` before using it as a VLA size. The check `if (n_entries < 0)` is appropriate. Note that the function signature of `rte_cfgfile_section_num_entries()` returns `int` and documents -1 on error, so the check is correct.
The error code `-1` is propagated upward, which is consistent with the function's existing error handling pattern (other error paths in `cfg_load_subport()` also return `-1`).
**3. Pattern suitability**
Using a VLA with a runtime-checked size is acceptable in this context (config file parsing in an example application). The alternative would be dynamic allocation (`malloc`), which would add overhead for a bounded, typically small array. The VLA is bounded by the number of entries in a config file section, which is not untrusted network input.
Review-Result: CLEAN
More information about the test-report
mailing list