|WARNING| pw170595 [PATCH v4 22/24] net/i40e: reimplement tunnel parsers

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/170595

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#3557: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:186:
+			[8] = I40E_REPLACE_VALID(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#3568: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:197:
+			[0] = I40E_REPLACE_VALID(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#3586: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:215:
+			[8] = I40E_REPLACE_VALID(

ERROR:CODE_INDENT: code indent should use tabs where possible
#4077: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:706:
+^I^I^I               FLOW_GRAPH_NODE_EXPECT_SPEC,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#4102: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:731:
+^I^I^I               FLOW_GRAPH_NODE_EXPECT_SPEC,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#4110: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:739:
+^I^I^I               FLOW_GRAPH_NODE_EXPECT_SPEC,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#4286: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:915:
+^I^I^I               FLOW_GRAPH_NODE_EXPECT_SPEC,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#4306: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:935:
+^I^I^I               FLOW_GRAPH_NODE_EXPECT_SPEC,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#4314: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:943:
+^I^I^I               FLOW_GRAPH_NODE_EXPECT_SPEC,$

CHECK:CAMELCASE: Avoid CamelCase: <I40E_TUNNEL_TYPE_MPLSoUDP>
#4403: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:1032:
+	tunnel_filter->tunnel_type = I40E_TUNNEL_TYPE_MPLSoUDP;

CHECK:CAMELCASE: Avoid CamelCase: <I40E_TUNNEL_TYPE_MPLSoGRE>
#4415: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:1044:
+	tunnel_filter->tunnel_type = I40E_TUNNEL_TYPE_MPLSoGRE;

CHECK:BRACES: braces {} should be used on all arms of this statement
#4603: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:1232:
+	if (item->type == RTE_FLOW_ITEM_TYPE_GTPC)
[...]
+	else if (item->type == RTE_FLOW_ITEM_TYPE_GTPU)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#4607: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:1236:
+	else {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#5165: FILE: drivers/net/intel/i40e/i40e_flow_tunnel.c:1794:
+	} else if (state->configured_recipe != I40E_TUNNEL_REPLACEMENT_DEFAULT) {
+			return rte_flow_error_set(error, EBUSY,

total: 6 errors, 1 warnings, 7 checks, 5179 lines checked