|WARNING| net/bnxt: fix flow db lock-free issue during shutdown

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170563

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-05

# DPDK Patch Review

## Summary
This patch fixes a lock ordering issue in the bnxt driver's cleanup path where table scope cleanup was happening after the protecting mutex had already been destroyed.

---

## Errors

None found. The patch correctly addresses a lock-after-destroy issue.

---

## Warnings

None found.

---

## Info

**Positive observations:**

1. **Correctness fix**: The patch correctly identifies and fixes a use-after-destroy bug where `ulp_tfc_tbl_scope_deinit()` would access `flow_db_lock` after it had been destroyed by `pthread_mutex_destroy()`. The reordering ensures the lock is available during table scope cleanup.

2. **Minimal change**: The fix is surgical - only reorders two function calls to establish correct cleanup sequencing.

3. **Proper attribution**: Includes `Fixes:` tag and `Cc: stable at dpdk.org` for backporting.

**No issues to report.**

The patch is correct as written.