|WARNING| net/bnxt: fix completion metadata format type for Thor

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170627

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-06

# DPDK Patch Review

## Patch Summary
This patch fixes the RX completion metadata format type for Thor (non-Thor2) devices in the Broadcom bnxt driver. The metadata format is changed from Type 3 to Type 1 for Thor devices.

---

## CORRECTNESS BUGS

**None found.** The patch correctly:
- Checks the device ID to select the appropriate metadata format
- Maintains proper error handling (existing `if (unlikely(rc))` check after `bnxt_hwrm_vnic_update()`)
- Does not introduce resource leaks or use-after-free issues
- Does not modify the error cleanup path

---

## C CODING STYLE

### Error: Line Length Violation

**Lines 488-489 exceed 100 characters:**
```c
rc = bnxt_hwrm_vnic_update(bp,
		vnic,
		HWRM_VNIC_UPDATE_INPUT_ENABLES_METADATA_FORMAT_TYPE_VALID);
```

**Fix:** The continuation is correctly double-indented per DPDK style, but the alignment should match the opening parenthesis on the first line:

```c
rc = bnxt_hwrm_vnic_update(bp, vnic,
		HWRM_VNIC_UPDATE_INPUT_ENABLES_METADATA_FORMAT_TYPE_VALID);
```

or break differently if needed to stay under 100 characters while maintaining readability.

---

## API AND DOCUMENTATION

**Warning: Missing Release Notes Update**

This patch fixes a bug that affects Thor device behavior (wrong metadata format causes misinterpretation of completion records). This is a significant functional fix that should be documented in the current release notes.

**Suggested action:** Add an entry to `doc/guides/rel_notes/release_XX_XX.rst` (where XX_XX is the target release) under the "Fixed Issues" section:

```rst
* **net/bnxt: Fixed completion metadata format for Thor devices.**

  Corrected the RX completion record metadata format type for Thor devices
  from Type 3 to Type 1, fixing potential misinterpretation of completion
  records.
```

**Note:** The `Cc: stable at dpdk.org` tag is correctly present for backporting to stable releases.

---

## SUMMARY

**Errors:** 1 (line length)  
**Warnings:** 1 (missing release notes)  
**Info:** 0

The patch is functionally correct with no correctness bugs. The issues found are:
1. Minor style violation (line length can be improved)
2. Missing release notes for a functional fix

The core logic change (device ID check and metadata format selection) is sound and properly implemented.