|WARNING| net/bnxt: fix promiscuous mode set

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170626

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-06

# DPDK Patch Review

## Patch Summary
The patch adds a platform check to skip promiscuous mode set operations on unsupported platforms (Whitney), allowing the operation only on Thor (P5) and Thor2 (P7) platforms.

---

## Findings

### Errors

**1. Uninitialized return value used on success path**

The variable `rc` is never initialized but is returned when the function skips promiscuous mode set on unsupported platforms. This returns an indeterminate value instead of 0 for success.

```c
int rc;  /* Uninitialized */

if (ULP_APP_DEV_UNSUPPORTED_ENABLED(bp->ulp_ctx->cfg_data->ulp_flags) ||
    !bp->ulp_ctx)
    return rc;  /* May return garbage if both conditions false */

if (!BNXT_CHIP_P5_P7(bp))
    return rc;  /* Returns uninitialized value */
```

**Suggested fix:**

```c
int rc = 0;  /* Initialize to success */
```

Or more explicitly:

```c
if (!BNXT_CHIP_P5_P7(bp))
    return 0;  /* Success - skip unsupported platform */
```

The second approach is clearer about intent: skipping the operation on an unsupported platform is not an error, it's a successful no-op.

---

### Warnings

None.

---

### Info

**1. Consider early return consolidation**

The function has two separate checks that return early with `rc`. These could potentially be combined for clarity, though the current structure is acceptable:

```c
if (ULP_APP_DEV_UNSUPPORTED_ENABLED(bp->ulp_ctx->cfg_data->ulp_flags) ||
    !bp->ulp_ctx || !BNXT_CHIP_P5_P7(bp))
    return 0;
```

However, the patch as written is fine from a readability standpoint - the platform check is separate and well-commented. This is only a minor style suggestion.

---

## Summary

The patch has **one critical correctness bug**: the return value `rc` is uninitialized when the function returns on the new early-exit path for unsupported platforms. Initialize `rc = 0` at declaration or explicitly return `0` on the unsupported platform path.