|WARNING| pw170824 [PATCH v5 22/25] net/i40e: reimplement FDIR parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/170824

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#1196: FILE: drivers/net/intel/i40e/i40e_fdir.c:1569:
+	if (ci_usage_count_release(&fdir_info->fdir_rule_count)) {
+		i40e_fdir_rx_proc_sync(dev->data);
+	}

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#3582: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:48:
+ * Pattern: START -> ETH -> [VLAN] -> (IPv4 | IPv6) -> [TCP | UDP | SCTP | ESP | L2TPv3 | GTP] -> END

WARNING:LONG_LINE: line length of 125 exceeds 100 columns
#4017: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:483:
+		memcpy(&fdir_filter->input.flow.ipv6_flow.src_ip, &ipv6_spec->hdr.src_addr, sizeof(ipv6_spec->hdr.src_addr));

WARNING:LONG_LINE: line length of 125 exceeds 100 columns
#4021: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:487:
+		memcpy(&fdir_filter->input.flow.ipv6_flow.dst_ip, &ipv6_spec->hdr.dst_addr, sizeof(ipv6_spec->hdr.dst_addr));

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#4101: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:567:
+	if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#4187: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:653:
+	if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#4277: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:743:
+	if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#4286: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:752:
+	if (!CI_FIELD_IS_ZERO(&sctp_mask->hdr.tag)) {
+		fdir_filter->input.flow_ext.input_set |= I40E_INSET_SCTP_VT;
+	}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#4565: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1031:
+		if (is_udp)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#4567: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1033:
+		else {

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#4571: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1037:
+		if (is_udp)
[...]
+		else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#4573: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1039:
+		else {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#4595: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1061:
+
+}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#4611: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1077:
+	if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV4) {
[...]
+	} else if (fdir_filter->input.flow_ext.oip_type == I40E_FDIR_IPTYPE_IPV6) {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#5129: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1595:
+	if (ret) {
+		return ret;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#5134: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1600:
+	if (ret) {
+		return ret;
+	}

CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#5379: FILE: drivers/net/intel/i40e/i40e_flow_fdir.c:1845:
+	needs_wait = fdir_flow->installed == false &&

total: 0 errors, 13 warnings, 4 checks, 5524 lines checked