|WARNING| pw170817 [PATCH v5 15/25] net/ixgbe: reimplement FDIR parser

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/170817

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#3587: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:573:
+^I^I^I               FLOW_GRAPH_NODE_EXPECT_SPEC,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3615: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:601:
+^I^I^I               FLOW_GRAPH_NODE_EXPECT_SPEC,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3623: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:609:
+^I^I^I               FLOW_GRAPH_NODE_EXPECT_SPEC,$

WARNING:LONG_LINE_COMMENT: line length of 115 exceeds 100 columns
#3724: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:710:
+ * Pattern: START -> [OUTER_ETH] -> (OUTER_IPv4|OUTER_IPv6) -> [UDP] -> (VXLAN|NVGRE) -> INNER_ETH -> [VLAN] -> END

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#3725: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:711:
+ * VxLAN:  START -> [OUTER_ETH] -> (OUTER_IPv4|OUTER_IPv6) -> UDP -> VXLAN -> INNER_ETH -> [VLAN] -> END

WARNING:BRACES: braces {} are not necessary for single statement blocks
#3909: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:895:
+		if (eth_mask->hdr.dst_addr.addr_bytes[j] == 0xFF) {
+			rule->mask.mac_addr_byte_mask |= 0x1 << j;
+		}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fdir_ctx->rule.mode == RTE_FDIR_MODE_SIGNATURE'
#4172: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1158:
+	if ((fdir_ctx->rule.mode == RTE_FDIR_MODE_SIGNATURE) &&
+	    (fdir_ctx->fwd_action->type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fdir_ctx->fwd_action->type == RTE_FLOW_ACTION_TYPE_DROP'
#4172: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1158:
+	if ((fdir_ctx->rule.mode == RTE_FDIR_MODE_SIGNATURE) &&
+	    (fdir_ctx->fwd_action->type == RTE_FLOW_ACTION_TYPE_DROP)) {

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#4236: FILE: drivers/net/intel/ixgbe/ixgbe_flow_fdir.c:1222:
+	if (fdir_ctx->aux_action != NULL && fdir_ctx->aux_action->type == RTE_FLOW_ACTION_TYPE_MARK) {

total: 3 errors, 4 warnings, 2 checks, 4388 lines checked