|WARNING| [20/20] mempool: promote memory range and alignment to stable

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170849

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-07

I'll review these DPDK patches against the AGENTS.md guidelines, focusing on correctness bugs, C coding style, API requirements, and other violations.

## PATCH 01/20: eal: add missing export for rte_basename

**Errors:**
None found. The patch correctly adds the missing `RTE_EXPORT_EXPERIMENTAL_SYMBOL` macro and include for Windows, matching the Unix implementation.

---

## PATCH 02/20: eal: promote rte_basename to stable

**Errors:**
None found. Straightforward promotion from experimental to stable symbol, with `__rte_experimental` removed from header.

---

## PATCH 03/20: eal: promote explicit zero and sensitive free to stable

**Errors:**
None found. Clean promotion of security-related functions that have been stable since 25.07.

---

## PATCH 04/20: eal: promote rte_size_to_str to stable

**Errors:**
None found. Consistent with its counterpart `rte_str_to_size` already being stable.

---

## PATCH 05/20: eal: promote lcore variables API to stable

**Errors:**
None found. The patch correctly promotes the allocator while leaving the macros (which were never marked experimental) as-is.

---

## PATCH 06/20: cmdline: promote bool token ops to stable

**Errors:**
None found. Simple promotion of a single structure export.

---

## PATCH 07/20: ethdev: promote link connector to string to stable

**Errors:**
None found. Consistent with `rte_eth_link_speed_to_str()` already being stable; pure enum-to-string helper with no driver involvement.

---

## PATCH 08/20: port: promote SWX port API to stable

**Errors:**
None found. Clean promotion of ops structures that haven't changed since introduction.

---

## PATCH 09/20: table: promote SWX table API to stable

**Errors:**
None found. Straightforward promotion of table operations.

---

## PATCH 10/20: pipeline: promote SWX IPsec API to stable

**Errors:**
None found. All symbols promoted consistently.

---

## PATCH 11/20: pipeline: promote SWX pipeline and control API to stable

**Errors:**
None found. Large batch promotion of many symbols, all changed from `RTE_EXPORT_EXPERIMENTAL_SYMBOL` to `RTE_EXPORT_SYMBOL` correctly.

---

## PATCH 12/20: power: promote PM QoS and uncore API to stable

**Errors:**
None found. Clean promotion of power management functions.

---

## PATCH 13/20: ring: promote soring API to stable

**Errors:**
None found. The patch correctly promotes the core soring functions while leaving the peek and dump functions experimental as documented.

---

## PATCH 14/20: dispatcher: promote API to stable

**Errors:**
None found. Clean promotion of the entire dispatcher library after two years of stability.

---

## PATCH 15/20: argparse: promote API to stable

**Errors:**
None found. All three argparse functions promoted correctly, and `rte_compat.h` include properly removed.

---

## PATCH 16/20: node: promote API to stable

**Errors:**
None found. Comprehensive promotion of node control path functions with file-level experimental warnings removed.

---

## PATCH 17/20: hash: promote RCU reclaim and thash key generation to stable

**Errors:**
None found. Two isolated function promotions, rest of API already stable.

---

## PATCH 18/20: cryptodev: promote algorithm helpers to stable

**Errors:**
None found. The patch promotes algorithm name lookups and capability checks while correctly leaving driver-specific functions (queue pair reset, event error query) experimental.

---

## PATCH 19/20: pdcp: promote API to stable

**Errors:**
None found. Entire library promoted after being unchanged since 23.07.

---

## PATCH 20/20: mempool: promote memory range and alignment to stable

**Errors:**
None found. Two query functions promoted while trace points and stats reset remain experimental.

---

## Summary

**No errors or warnings found across any of the 20 patches.**

All patches follow the guidelines correctly:
- Symbol exports changed from `RTE_EXPORT_EXPERIMENTAL_SYMBOL(name, version)` to `RTE_EXPORT_SYMBOL(name)`
- `__rte_experimental` removed from function declarations
- File-level experimental warnings removed where appropriate
- `rte_compat.h` includes removed when no longer needed
- Release notes updated appropriately
- Selective promotion applied (e.g., leaving driver-specific or recent additions experimental)

The patch series demonstrates good judgment about what to promote: functions that have been stable for 1-2+ years, are used by applications/examples, and have well-established interfaces. Items left experimental are appropriately recent or implemented by only a single driver.