|WARNING| dma/idxd: remove experimental on whole driver
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Oct 9 00:57:50 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170857
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-08
# DPDK Patch Review
## Patch Summary
This patch removes the "EXPERIMENTAL" designation from the Intel IDXD DMA driver in the MAINTAINERS file.
---
## Review Findings
### Errors
None.
### Warnings
**1. Inappropriate Fixes tag** (Warning)
The `Fixes:` tag references commit `e33ad06eaeeb` which added the driver skeleton. This is incorrect usage of the `Fixes:` tag. The `Fixes:` tag should only reference commits that introduced a bug being fixed. Removing an experimental designation is not a bug fix - it's a status change/graduation of a stable API.
**Suggested fix:** Remove the `Fixes:` tag entirely. This is a feature graduation, not a bug fix.
```diff
-Fixes: e33ad06eaeeb ("dma/idxd: add skeleton for VFIO based DSA device")
-Cc: stable at dpdk.org
-
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
```
**Rationale:** The commit message itself acknowledges "there is no good commit point to use to identify the stabilization of the driver" and uses the original driver addition as a workaround. This confirms it's not actually fixing that commit. The `Cc: stable at dpdk.org` also becomes inappropriate without a `Fixes:` tag.
**2. Missing release notes** (Warning)
Removing experimental status from a driver is a significant milestone that should be documented in the release notes. Users tracking driver maturity would want to know about this change.
**Suggested fix:** Add an entry to `doc/guides/rel_notes/release_XX_YY.rst` (where XX_YY is the target release version):
```rst
* **Graduated Intel IDXD DMA driver from experimental status.**
The Intel IDXD DMA driver is no longer marked as experimental and is
considered stable for production use.
```
---
### Info
None.
---
## Summary
The patch correctly updates the MAINTAINERS file format and content. However:
1. The `Fixes:` tag usage is inappropriate - this is not a bug fix but a status graduation
2. Release notes should document this driver maturity change
The code change itself (removing "- EXPERIMENTAL" from the MAINTAINERS entry) is correct and properly formatted.
More information about the test-report
mailing list