|WARNING| drivers: remove driver alias macro

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170896

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-09

# DPDK Patch Review

## Summary
This patch removes the `RTE_PMD_REGISTER_ALIAS` macro and its clones, replacing them with direct `.driver.alias` initialization in driver structures. The change is a refactoring that simplifies the driver registration pattern.

---

## Errors

None identified.

---

## Warnings

### 1. Missing Release Notes Update
**Issue:** The patch makes a significant change to the driver registration API pattern by removing `RTE_PMD_REGISTER_ALIAS` and its variants, but does not update the release notes.

**Why it matters:** This is an API/process change that affects driver developers and should be documented in `doc/guides/rel_notes/release_*.rst`.

**Suggested fix:** Add a release notes entry under "Removed Items" or "API Changes" documenting:
- Removal of `RTE_PMD_REGISTER_ALIAS` macro from vdev bus
- Removal of `RTE_PMD_REGISTER_AFU_ALIAS` from ifpga bus  
- Removal of `RTE_PMD_REGISTER_ALIAS` from platform bus
- Recommendation to set `.driver.alias` directly in driver structures

---

### 2. Missing Deprecation Notice Removal
**Issue:** If `RTE_PMD_REGISTER_ALIAS` was previously marked as deprecated in `doc/guides/rel_notes/deprecation.rst`, that notice should be removed as part of this patch.

**Suggested fix:** Check deprecation.rst and remove any related entries if present.

---

## Info

### 1. Consistent Trailing Comma Style
**Observation:** The patch consistently adds trailing commas after `.remove` field initialization:

```c
static struct rte_vdev_driver bbdev_null_pmd_drv = {
	.driver.alias = "bbdev_null",
	.probe = null_bbdev_probe,
	.remove = null_bbdev_remove,  // Added trailing comma
};
```

This is a good defensive programming practice that prevents diff noise when new fields are added later.

---

### 2. Clean Removal of Dead Code
The patch properly removes the now-unused macro infrastructure:
- Static pointer declarations (`vdrvinit_ ## nm ## _alias`)
- Macro assignment patterns
- Unused macros in ifpga and platform buses

This cleanup is thorough and correct.

---

### 3. Pattern Consistency
All 24 driver conversions follow the same pattern:
1. Add `.driver.alias = "string"` as first field
2. Ensure trailing comma on last field
3. Remove corresponding `RTE_PMD_REGISTER_ALIAS` call

The mechanical consistency reduces the risk of errors.

---

## Conclusion

The patch is **technically correct** with no correctness bugs, style violations, or forbidden patterns. The only actionable item is adding appropriate release notes documentation for this API pattern change.