|WARNING| drivers/crypto: remove dead code for NXP driver names

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/170970

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-09

# DPDK Patch Review

**Patch:** drivers/crypto: remove dead code for NXP driver names

## Summary

This patch removes dead code that initializes driver name fields in two NXP crypto drivers. The driver names are overwritten by registration macros, making these initializations unnecessary.

---

## Findings

### Errors

None.

### Warnings

**Release notes missing (Warning)**

This patch removes dead code from two crypto drivers (dpaa_sec and dpaa2_sec). While this is a cleanup change, it modifies driver code and should be documented in the release notes under a "Removed Items" or "Code Cleanup" section to maintain transparency about driver changes.

The release notes should briefly mention:
- Dead code removal from dpaa_sec and dpaa2_sec crypto drivers
- Driver name initialization removed as it was overwritten by registration macros

Example release note entry:
```
* **Removed dead code from NXP crypto drivers.**

  Removed unused driver name initialization from dpaa_sec and dpaa2_sec
  crypto drivers. Driver names are set by RTE_PMD_REGISTER_DPAA/DPAA2
  macros at registration time.
```

### Info

**Code cleanup observation (Info)**

The patch correctly identifies and removes dead code. The `driver.name` field in both `rte_dpaa_sec_driver` and `rte_dpaa2_sec_driver` structures is indeed overwritten when `RTE_PMD_REGISTER_DPAA` and `RTE_PMD_REGISTER_DPAA2` macros are invoked at the end of each driver file. This is a valid cleanup that reduces unnecessary code.

---

## Style and Correctness Checks

- [x] No correctness bugs identified
- [x] No resource leaks
- [x] No use-after-free issues
- [x] No race conditions
- [x] No forbidden tokens
- [x] C coding style compliant
- [x] No deprecated API usage
- [x] No ABI breaks (pure deletion of dead code)
- [x] Code compiles independently (only removes unused initializers)

---

## Recommendation

**Accept with minor suggestion:** Add a brief note to the current release notes documenting this cleanup change.