|SUCCESS| drivers/crypto: remove dead code for NXP driver names
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Oct 9 15:15:20 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/170970
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-09
# DPDK Patch Review
## Patch Summary
This patch removes dead code from two NXP crypto drivers (dpaa2_sec and dpaa_sec) by deleting unused driver name initializations that are overwritten by registration macros.
---
## Review Findings
### **ERRORS**
None.
### **WARNINGS**
None.
### **INFO**
**1. Missing release notes update**
The patch removes code from two PMDs but does not update release notes. While this is a minor internal cleanup (removing dead code rather than changing behavior), documenting the removal in the release notes provides transparency about what changed in the drivers.
**Suggested fix:**
Add a note to `doc/guides/rel_notes/release_26_11.rst` (or the appropriate current release notes file) under a "Removed Items" or "Other Changes" section:
```rst
* **crypto/dpaa2_sec, crypto/dpaa_sec**: Removed dead driver name initialization.
The ``driver.name`` field initialization was removed from both drivers
as it was overwritten at registration time by the
``RTE_PMD_REGISTER_DPAA/DPAA2`` macros.
```
---
## Summary
The patch is correct and improves code clarity by removing initialization that was indeed overwritten by the `RTE_PMD_REGISTER_DPAA2()` and `RTE_PMD_REGISTER_DPAA()` macros (these macros set the driver name to their first string argument, making the `.driver.name` field in the structure initialization dead code).
The only suggestion is to add a brief release notes entry for completeness, though this is a minor point for an internal cleanup change.
More information about the test-report
mailing list