|SUCCESS| eal: prefix lcore role values

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171097

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-13

# DPDK Patch Review

## Errors

None identified.

## Warnings

None identified.

## Info

### Positive Observations

**Code correctness:**
- All enum value substitutions are mechanically correct throughout the codebase
- Backward compatibility preserved with macro aliases
- No logic changes, only naming consistency improvements
- Error handling paths unchanged and appear correct

**Style compliance:**
- New enum values follow DPDK naming convention (`RTE_` prefix on all capitals)
- Enum values use ALL_UPPERCASE as required
- Backward compatibility macros properly defined
- Comments updated to reference new names

**Documentation:**
- Doxygen comment in `rte_lcore.h` updated to use new enum names
- Internal comments in `eal_private.h` updated consistently

**Process:**
- This is a pure rename with backward compatibility, appropriate for a non-LTS release
- The patch note correctly identifies this is easier in 26.11 due to lack of ABI checks

### Technical Assessment

The patch performs a systematic rename of lcore role enum values to add the `RTE_LCORE_` prefix,
which aligns with DPDK naming standards. All internal uses are updated atomically,
and the old names are preserved as macros to maintain backward compatibility for external users.

The changes span:
- 2 test files
- 1 driver (softnic)
- 4 EAL implementation files
- 2 EAL headers
- 1 graph library file

All substitutions follow the pattern:
- `ROLE_RTE` - `RTE_LCORE_ROLE_RTE`
- `ROLE_OFF` - `RTE_LCORE_ROLE_OFF`
- `ROLE_SERVICE` - `RTE_LCORE_ROLE_SERVICE`
- `ROLE_NON_EAL` - `RTE_LCORE_ROLE_NON_EAL`

The mechanical nature of the change and preservation of backward compatibility
reduce the risk of introducing bugs.

Review-Result: CLEAN